Skip to content

Add validation to check if backendId exists when --only flag is used #10170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joehan merged 5 commits into from
Mar 31, 2026
Merged

Add validation to check if backendId exists when --only flag is used #10170

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b42c794
add validation to check if backendId exists when --only flag is used
aalej Mar 25, 2026
6d4b62b
add changelog entry
aalej Mar 25, 2026
507eca5
add tests
aalej Mar 25, 2026
042a149
typo
aalej Mar 25, 2026
e16ee96
Merge branch 'main' into aalej_fix-10161
joehan Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/deploy/apphosting/prepare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,5 +210,15 @@ export function getBackendConfigs(options: Options): AppHostingMultiple {
if (backendIds.length === 0) {
return [];
}
return backendConfigs.filter((cfg) => backendIds.includes(cfg.backendId));

const filteredConfigs = backendConfigs.filter((cfg) => backendIds.includes(cfg.backendId));
const foundIds = filteredConfigs.map((cfg) => cfg.backendId);
const missingIds = backendIds.filter((id) => !foundIds.includes(id));
if (missingIds.length > 0) {
throw new FirebaseError(
`App Hosting backend IDs ${missingIds.join(",")} not detected in firebase.json`,
);
Comment thread
joehan marked this conversation as resolved.
}

return filteredConfigs;
}
Loading