Revert "Throttle CRF to two concurrent deploys"

[asperpharma]

Reverts #10173

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a prior change that temporarily restricted concurrent Cloud Run Function deployments. By eliminating the specialized runFunctionExecutor and its associated concurrency limit, the system will no longer impose a two-concurrent-deploy restriction on Cloud Run Functions, allowing them to operate under the general executor's concurrency settings. This change streamlines the deployment process by removing a temporary workaround.

Highlights

• Revert Throttling: This pull request reverts a previous change that introduced a temporary throttle on concurrent Cloud Run Function (CRF) deploys, specifically limiting them to two concurrent operations.
• Executor Consolidation: The dedicated runFunctionExecutor and its associated logic have been removed from the Fabricator class and its instantiation. All function deployment operations now utilize the general executor.
• Code Cleanup: Removed unused runFunctionExecutor properties from interfaces, classes, and constructor arguments across several files, simplifying the deployment logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Fabricator class by removing the dedicated runFunctionExecutor and consolidating its responsibilities into the general executor. This change simplifies the FabricatorArgs interface, the class properties, and the usage of executors for Cloud Run function operations (create, update, delete). A review comment points out that this change might inadvertently reduce the concurrency for deleting Cloud Run functions in the firebase functions:delete command, potentially slowing down bulk deletions. It is recommended to ensure the executor in src/commands/functions-delete.ts is initialized with the same concurrency options as the functionExecutor to maintain consistent behavior.

[kevmoo]

Did it break something?

[inlined]

This is a modification to an unreleased feature. Unless there's an actual bug to report, we are closing the PR.