-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove globs from default Firestore rules #8510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joehan
wants to merge
3
commits into
master
Choose a base branch
from
jh-sec-rules-globs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,14 @@ | ||
service cloud.firestore { | ||
match /databases/{database}/documents { | ||
match /{document=**} { | ||
// This rule allows anyone with your database reference to view, edit, | ||
// and delete all data in your database. It is useful for getting | ||
// started, but it is configured to expire after 30 days because it | ||
// leaves your app open to attackers. At that time, all client | ||
// requests to your database will be denied. | ||
// | ||
// Make sure to write security rules for your app before that time, or | ||
// else all client requests to your database will be denied until you | ||
// update your rules. | ||
allow read, write: if request.time < timestamp.date({{IN_30_DAYS}}); | ||
} | ||
// This rule allows anyone with your database reference to view, edit, | ||
// and delete all data in your database. It is useful for getting | ||
// started, but it is configured to expire after 30 days because it | ||
// leaves your app open to attackers. At that time, all client | ||
// requests to your database will be denied. | ||
// | ||
// Make sure to write security rules for your app before that time, or | ||
// else all client requests to your database will be denied until you | ||
// update your rules. | ||
allow read, write: if request.time < timestamp.date({{IN_30_DAYS}}); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.