[FDC init] Move the default value to actuate #8554
Open
+22
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
commented
May 13, 2025
| isBillingEnabled: boolean, | ||
| ): Promise<RequiredInfo> { | ||
| if (!setup.projectId || !isBillingEnabled) { | ||
| // TODO(b/368609569): Don't gate this behind billing once backend billing fix is rolled out. |
There was a problem hiding this comment.
Got rid of the isBillingEnabled check here because we no longer needs it.
FDC API can be used without billing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the default values from
askQuestionstoactuate.This way the MCP tool can pass in an empty config and lets the
actuatestep populates the standard default value.Scenarios Tested
firebase initlocally, it is still able to finds the right service and pulls it down.firebase deployrequires billing as usually.Sample Commands