Fix issue where projectId and displayName are not getting parsed

[aalej]

Description

Fixes #8634

Scenarios Tested

with [projectId] param

$ firebase projects:create some-project-id
? What would you like to call your project? (defaults to your project ID) (some-project-id)

$ firebase projects:create some-project-id
✔ What would you like to call your project? (defaults to your project ID) some-project-id
✖ Creating Google Cloud Platform project

Error: Failed to create project because there is already a project with ID some-project-id. Please try again with a unique project ID.

with [display-name] option

$ firebase projects:create some-project-id-0123456 --display-name some-display-name
✔ Creating Google Cloud Platform project
✔ Adding Firebase resources to Google Cloud Platform project

🎉🎉🎉 Your Firebase project is ready! 🎉🎉🎉

Project information:
   - Project ID: some-project-id-0123456
   - Project Name: some-display-name

Firebase console is available at
https://console.firebase.google.com/project/some-project-id-0123456/overview

Sample Commands

firebase projects:create some-project-id

[joehan]

LGTM with some type nits.

[joehan]

this should probably be options: Options, right?

[aalej]

Thanks for the feedback! didn't know we had an Options type, will update!

[joehan]

Same, probably should use Options as the type here.

[aalej]

It looks like using the Options type raises and error

I'm guessing this is because displayName is not a property in either Options or BaseOptions, so displayName gets cast as unknown in [key: string]: unknown;

firebase-tools/src/options.ts

Lines 6 to 41 in d965588

	export interface BaseOptions {
	cwd: string;
	configPath: string;
	only: string;
	except: string;
	config: Config;
	filteredTargets: string[];
	force: boolean;
	// Options which are present on every command
	project?: string;
	projectAlias?: string;
	projectId?: string;
	projectNumber?: string;
	projectRoot?: string;
	account?: string;
	json: boolean;
	nonInteractive: boolean;
	interactive: boolean;
	debug: boolean;
	rc: RC;
	// Emulator specific import/export options
	exportOnExit?: boolean | string;
	import?: string;
	isMCP?: boolean;
	}
	export interface Options extends BaseOptions {
	// TODO(samstern): Remove this once options is better typed
	[key: string]: unknown;
	// whether it's coming from the VS Code Extension
	isVSCE?: true;
	}

Would it be okay to add displayName as a property in Options. Something like