-
Notifications
You must be signed in to change notification settings - Fork 1k
Add support for loading TypeScript functions using tsx in the Functions Emulator #8663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taeold
wants to merge
8
commits into
master
Choose a base branch
from
dl-fn-emu-ts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for loading TypeScript functions using tsx in the Functions Emulator so that developers can run TypeScript files directly without a separate compile step.
- Added tsx as a dependency in package files.
- Updated the functions emulator runtime and delegate logic to override the entry point for TypeScript projects.
- Introduced getTypeScriptEntryPoint to resolve the TypeScript source file and added an isEmulator flag to control TS-specific behavior.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
templates/init/functions/typescript/package.nolint.json | Added the "tsx" dependency alongside firebase-functions-test. |
templates/init/functions/typescript/package.lint.json | Added the "tsx" dependency alongside typescript. |
src/emulator/functionsEmulatorRuntime.ts | Modified trigger loading to check for a custom entry point for TS files. |
src/emulator/functionsEmulator.ts | Introduced the isEmulator flag and set FUNCTIONS_SOURCE in the env vars. |
src/deploy/functions/runtimes/node/index.ts | Added getTypeScriptEntryPoint and updated Delegate to support TS projects. |
src/deploy/functions/runtimes/index.ts | Extended DelegateContext with isEmulator flag. |
CHANGELOG.md | Documented support for loading TypeScript functions with tsx. |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emulator will try to detect use of TypeScript by checking existence of
tsconfig.json
and will prefer usingtsx
in place ofnode
to start the process for loading and executing functions.This allows developers to skip running TS compilation on the side -
index.ts
file will be read directly by the Functions Emulator!