Skip to content

Update typings for Gemini in Firebase api calls #8691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025
Merged

Conversation

hlshen
Copy link
Contributor

@hlshen hlshen commented Jun 2, 2025

Add types file for Cloud AI Companion experience calls.
Add chat history as an optional input.

Follow up PR to migrate FDC VSCode to use this API file.

@joehan
Copy link
Contributor

joehan commented Jun 2, 2025

Also looks like this broke the vsce unit tests - lets fix those first.

@hlshen
Copy link
Contributor Author

hlshen commented Jun 2, 2025

Also looks like this broke the vsce unit tests - lets fix those first.

This is unrelated to this PR. However, I have a fix in #8693

Copy link
Contributor

@nohe427 nohe427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlshen hlshen enabled auto-merge (squash) June 3, 2025 15:41
@hlshen hlshen merged commit 3abd9bb into master Jun 3, 2025
48 of 50 checks passed
@hlshen hlshen deleted the hlshen/gca-backend branch June 3, 2025 15:52
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants