Addressed comments again

Author: maneesht

packages/firebase_data_connect/firebase_data_connect/lib/src/common/dataconnect_error.dart

@@ -48,20 +48,22 @@ class DataConnectOperationFailureResponse<T> {
 class DataConnectOperationFailureResponseErrorInfo {
   DataConnectOperationFailureResponseErrorInfo(this.path, this.message);
   String message;
-  List<PathSegment> path;
+  List<DataConnectOperationFailureErrorInfoPathSegment> path;
 }
 
 /// Path where error occurred.
-sealed class PathSegment {}
+sealed class DataConnectOperationFailureErrorInfoPathSegment {}
 
-class StringValue extends PathSegment {
-  final String value;
-  StringValue(this.value);
+class DataConnectOperationFailureErrorInfoFieldPathSegment
+    extends DataConnectOperationFailureErrorInfoPathSegment {
+  final String field;
+  DataConnectOperationFailureErrorInfoFieldPathSegment(this.field);
 }
 
-class IntValue extends PathSegment {
-  final int value;
-  IntValue(this.value);
+class DataConnectOperationFailureErrorInfoListIndexPathSegment
+    extends DataConnectOperationFailureErrorInfoPathSegment {
+  final int index;
+  DataConnectOperationFailureErrorInfoListIndexPathSegment(this.index);
 }
 
 typedef Serializer<Variables> = String Function(Variables vars);

packages/firebase_data_connect/firebase_data_connect/lib/src/network/grpc_transport.dart

@@ -180,8 +180,10 @@ Data handleResponse<Data>(CommonResponse<Data> commonResponse) {
         .map((e) => DataConnectOperationFailureResponseErrorInfo(
             e.path.values
                 .map((val) => val.hasStringValue()
-                    ? StringValue(val.stringValue)
-                    : IntValue(val.numberValue.toInt()))
+                    ? DataConnectOperationFailureErrorInfoFieldPathSegment(
+                        val.stringValue)
+                    : DataConnectOperationFailureErrorInfoListIndexPathSegment(
+                        val.numberValue.toInt()))
                 .toList(),
             e.message))
         .toList();

packages/firebase_data_connect/firebase_data_connect/lib/src/network/rest_transport.dart

@@ -150,8 +150,10 @@ class RestTransport implements DataConnectTransport {
             .map((e) => DataConnectOperationFailureResponseErrorInfo(
                 (e['path'] as List)
                     .map((val) => val.runtimeType == String
-                        ? StringValue(val)
-                        : IntValue(val))
+                        ? DataConnectOperationFailureErrorInfoFieldPathSegment(
+                            val)
+                        : DataConnectOperationFailureErrorInfoListIndexPathSegment(
+                            val))
                     .toList(),
                 e['message']))
             .toList();

packages/firebase_data_connect/firebase_data_connect/test/src/network/rest_transport_test.dart

@@ -422,7 +422,9 @@ void main() {
             e.response.data!['abc'] == 'def' &&
             e.response.errors.first.message ==
                 'SQL query error: pq: duplicate key value violates unique constraint movie_pkey' &&
-            (e.response.errors.first.path[0] as StringValue).value ==
+            (e.response.errors.first.path[0]
+                        as DataConnectOperationFailureErrorInfoFieldPathSegment)
+                    .field ==
                 'the_matrix' &&
             e.response.decodedData is AbcHolder &&
             (e.response.decodedData as AbcHolder).abc == 'def')),