Compose code for analytics #1654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfiredev
requested changes
Sep 2, 2024
...ics/app/src/main/java/com/google/firebase/quickstart/analytics/kotlin/ComposeMainActivity.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/firebase/quickstart/analytics/kotlin/FirebaseAnalyticsViewModel.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/firebase/quickstart/analytics/kotlin/FirebaseAnalyticsViewModel.kt
Outdated
Show resolved
Hide resolved
analytics/app/src/main/java/com/google/firebase/quickstart/analytics/kotlin/data/Constants.kt
Outdated
Show resolved
Hide resolved
- Create local variable for showFavoriteDialog - Pass shared preference in view mode factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit with fixes from previous review
Initial changes made:
Add Jetpack Compose option in EntryChoiceActivity
Removed business logic from MainActivity
Added FirebaseAnalyticsViewModel for business logic
Added ComposeMainActivity for the Jetpack Compose UI
Changes made after review
-Rename recordShare API to recordShareEvent
-Pass screenClass parameter in recordScreenView