fix(include-parser): infinite recursion or out-of-memory with symlinks/large projects - #1598
Merged
Merged
Conversation
superewald
marked this pull request as draft
June 30, 2025 15:11
superewald
force-pushed
the
fix-include-filescan
branch
from
July 1, 2025 09:39
efa7459 to
1da981e
Compare
superewald
marked this pull request as ready for review
July 1, 2025 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ParserIncludes.memoLocalRepoFilesfunction usedglobbyto memoize/cache the repository filenames. Since globby expands/projectto/project/**/*this would potentially cache immense amounts of filepaths that are useless for the context. If the repository contains local symlinks this can easily lead to the OOM crash described in #1588.This commit adds the
Utils.getTrackedFilesfunction that usesgit ls-filesto return the list of tracked files for the specific project, acknowledging .gitignores and avoiding untracked files to be memoized.Fixes #1588