fix: Attempt to cut down start up time for downloaded files - #1616
Closed
dxh9845 wants to merge 1 commit into
Closed
fix: Attempt to cut down start up time for downloaded files#1616dxh9845 wants to merge 1 commit into
dxh9845 wants to merge 1 commit into
Conversation
Owner
|
@dxh9845 Have you timed that these changes are actually faster than current version? Also, jest and eslint jobs are failing. |
bbrala
reviewed
Nov 29, 2025
| // Check remotely only if the file does not exist locally | ||
| const remoteFileExists = await Utils.remoteFileExist(cwd, f, ref, domain, projectPath, gitData.remote.schema, gitData.remote.port); | ||
| if (!remoteFileExists) { | ||
| continue |
Contributor
There was a problem hiding this comment.
Suggested change
| continue | |
| continue; |
bbrala
reviewed
Nov 29, 2025
|
|
||
| // Check remotely only if the file does not exist locally | ||
| const remoteFileExists = await Utils.remoteFileExist(cwd, f, ref, domain, projectPath, gitData.remote.schema, gitData.remote.port); | ||
| if (!remoteFileExists) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!remoteFileExists) { | |
| if (!remoteFileExists) { |
Owner
|
Feel free to reopen if you manage to provide some performance timings that shows an impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debugging the startup times for gitlab-ci-local, I noticed that remote includes were being downloaded everytime despite being already downloaded. Afaict this stops the downloads from happening, though I don't have confidence that the changes will work as expected.