fix: strip ports and digests from service aliases

[bidord]

Context

Service aliases containing registry ports (:443) or image digests (@sha256:...) are not stripped correctly, causing healthcheck failures.

See both examples below.

$ npx gitlab-ci-local --version
4.70.0

Job with a service name that includes a registry port

.gitlab-ci.yml

registry-port:
  services:
    - registry-1.docker.io:443/library/nginx:1.29.7
  image: docker.io/curlimages/curl:8.18.0
  script: curl -sS http://registry-1.docker.io-library-nginx/

Output

$ npx gitlab-ci-local registry-port
parsing and downloads finished in 32 ms.
json schema validated in 151 ms
registry-port starting docker.io/curlimages/curl:8.18.0 (test)
registry-port copied to docker volumes in 613 ms
registry-port started service image: registry-1.docker.io:443/library/nginx:1.29.7 with aliases: registry-1.docker.io:443-library-nginx, registry-1.docker.io:443__library__nginx in 477 ms
registry-port > still running...
registry-port > still running...
registry-port > still running...
registry-port service image: registry-1.docker.io:443/library/nginx:1.29.7 healthcheck failed
registry-port   Command failed with exit code 143: docker run --rm --name=gcl-wait-for-it-555055-0-80 --network 95cdffa9e5b4bdf5f8da2596af5a7a4bbc26b40e6c015387101bad1e44ddeae2 docker.io/sumina46/wait-for-it:latest registry-1.docker.io:443__library__nginx:80 -t 30
registry-port   wait-for-it.sh: waiting 30 seconds for registry-1.docker.io:443__library__nginx
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   nc: bad port '443__library__nginx'
registry-port   wait-for-it.sh: timeout occurred after waiting 30 seconds for registry-1.docker.io:443__library__nginx
registry-port also see (/home/bidord/dev/tmp/.gitlab-ci-local/services-output/registry-port/registry-1.docker.io:443/library/nginx:1.29.7-0.log)
registry-port $ curl -sS http://registry-1.docker.io-library-nginx/
registry-port > curl: (6) Could not resolve host: registry-1.docker.io-library-nginx
registry-port finished in 33 s  FAIL 6

 FAIL  registry-port
  > curl: (6) Could not resolve host: registry-1.docker.io-library-nginx

Job with a service name that includes a Docker image digest

This is common when using Renovate's digest pinning.

.gitlab-ci.yml

image-digest:
  services:
    - docker.io/library/nginx@sha256:e7257f1ef28ba17cf7c248cb8ccf6f0c6e0228ab9c315c152f9c203cd34cf6d1
  image: docker.io/curlimages/curl:8.18.0
  script: curl -sS http://docker.io-library-nginx/

Output

$ npx gitlab-ci-local image-digest
parsing and downloads finished in 27 ms.
json schema validated in 158 ms
image-digest starting docker.io/curlimages/curl:8.18.0 (test)
image-digest copied to docker volumes in 564 ms
image-digest started service image: docker.io/library/nginx@sha256:e7257f1ef28ba17cf7c248cb8ccf6f0c6e0228ab9c315c152f9c203cd34cf6d1 with aliases: docker.io-library-nginx@sha256, docker.io__library__nginx@sha256 in 470 ms
image-digest > still running...
image-digest > still running...
image-digest > still running...
image-digest service image: docker.io/library/nginx@sha256:e7257f1ef28ba17cf7c248cb8ccf6f0c6e0228ab9c315c152f9c203cd34cf6d1 healthcheck failed
image-digest   Command failed with exit code 143: docker run --rm --name=gcl-wait-for-it-122775-0-80 --network 9770fa5610032724d4fdc9b969b2b3f77698a18c622e3ef264739fdb49f29398 docker.io/sumina46/wait-for-it:latest docker.io__library__nginx@sha256:80 -t 30
image-digest   wait-for-it.sh: waiting 30 seconds for docker.io__library__nginx@sha256:80
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   nc: bad address 'docker.io__library__nginx@sha256'
image-digest   wait-for-it.sh: timeout occurred after waiting 30 seconds for docker.io__library__nginx@sha256:80
image-digest also see (/home/bidord/dev/tmp/.gitlab-ci-local/services-output/image-digest/docker.io/library/nginx@sha256:e7257f1ef28ba17cf7c248cb8ccf6f0c6e0228ab9c315c152f9c203cd34cf6d1-0.log)
image-digest $ curl -sS http://docker.io-library-nginx/
image-digest > curl: (6) Could not resolve host: docker.io-library-nginx
image-digest finished in 33 s  FAIL 6

 FAIL  image-digest
  > curl: (6) Could not resolve host: docker.io-library-nginx

Change

• Normalize service alias inference with 2 new utility functions Utils.getAllServiceAliases() and Utils.getServiceAlias()
• Use them in job.ts to fix the issue
• Add unit tests for new utility functions
• Add Docker tests (same as the above examples)

---

Summary by cubic

Fix service alias generation by stripping registry ports, tags, and digests so health checks resolve correctly and services start as expected. This prevents failures with registry ports (e.g., :443) and digest-pinned images.

• Bug Fixes
  • Centralized alias normalization in Utils.getAllServiceAliases and Utils.getServiceAlias (strip :port, :tag, @sha256:...; produce - and __ variants; honor custom aliases).
  • Updated job.ts to use these aliases for variable expansion and health checks.
  • Added unit tests for utils and integration tests for registry port and digest cases.

^{Written for commit 02ed47b. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 5 files

[firecow]

Solid fix. Strips registry ports and digests correctly from service aliases, deduplicates the alias logic, and has thorough test coverage.