Fix SonarCloud code smells

[firecow]

• Replace String#replace with String#replaceAll where appropriate
• Use node: prefixed imports (node:crypto, node:path)
• Use globalThis instead of global
• Use Number.parseInt/Number.isFinite instead of globals
• Extract nested ternary into if/else
• Fix Promise.allSettled receiving non-Promise values
• Use .find() instead of .filter()[0]
• Use for-of instead of indexed for loop
• Throw Error object instead of string literal
• Various minor cleanups (readonly, new Array(), String.raw, etc.)

---

Summary by cubic

Cleaned up SonarCloud code smells and fixed a few small bugs across the CLI. Safer APIs and better quoting make jobs more reliable.

• Bug Fixes

  • Avoid passing non-Promise values to Promise.allSettled during wait-for-it cleanup.
  • Safer numeric parsing in argv using Number.isFinite.
  • Fix single-quote escaping in docker env variables and services (correct shell quoting).
  • Throw proper Error objects (with cause) for registry port timeouts.

• Refactors

  • Prefer node: core imports (node:crypto, node:path) and globalThis.
  • Use replaceAll where appropriate; simplify loops and lookups (for-of, .find, new Array()).
  • Minor cleanups: readonly static, remove unnecessary spreads, clearer conditionals.

^{Written for commit 62df9af. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 10 files

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud