Allow to use component.reference, component.sha, component.version and component.name

[jrd]

When including another component B from a component A, allow to use $[[ component.reference ]] notation for component B.

[cubic-dev-ai]

2 issues found across 1 file

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[firecow]

Apply cubic's component\. suggestion — it's still open. And drop the compList.includes(...) check in getComponentValue; upstream GitLab doesn't require declaring spec.component, so just always allow reference, version, sha.

[jrd]

I updated my pull request, also borrowing the better idea from #1839

It should be all good now.

[firecow]

One behavior note (not blocking): getComponentSha runs a full git ls-remote on every remote component include, even when the template never uses $[[ component.sha ]]. Previously only semver ranges hit the network. Could the SHA be resolved lazily — only when the placeholder is actually present?

[jrd]

One behavior note (not blocking): getComponentSha runs a full git ls-remote on every remote component include, even when the template never uses $[[ component.sha ]]. Previously only semver ranges hit the network. Could the SHA be resolved lazily — only when the placeholder is actually present?

Yes, a lazy version is preferable in that case. I see what I can manage to do it in typescript. If I can find a better solution, a lambda/arrow function will do it.

[Edit] I think typescript have property, at least there is getter function in javascript, that could do the trick to compute it only when required.

[jrd]

@firecow Do you want me to squash the last two commits with the first one?

[firecow]

@firecow Do you want me to squash the last two commits with the first one?

Nah, don't care.. I'll squash into master anyway

[jrd]

So… what’s missing for merge?

[jrd]

Why no answer? Why not merge this?