Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
- run: bun install --frozen-lockfile
- name: Run Tests
run: bun run coverage
- uses: sonarsource/sonarqube-scan-action@v7.2
- uses: sonarsource/sonarqube-scan-action@v8.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This major-version bump changes skipSignatureVerification behavior implicitly. Set it explicitly in the workflow so the pipeline doesn't silently change behavior on upgrade.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/build.yml, line 86:

<comment>This major-version bump changes `skipSignatureVerification` behavior implicitly. Set it explicitly in the workflow so the pipeline doesn't silently change behavior on upgrade.</comment>

<file context>
@@ -83,7 +83,7 @@ jobs:
       - name: Run Tests
         run: bun run coverage
-      - uses: sonarsource/sonarqube-scan-action@v7.2
+      - uses: sonarsource/sonarqube-scan-action@v8.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
</file context>
Suggested change
- uses: sonarsource/sonarqube-scan-action@v8.0
- uses: sonarsource/sonarqube-scan-action@v8.0
with:
skipSignatureVerification: true

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down
Loading