fix artifact file ownership inside container builds#1846
Open
FredrikHson wants to merge 1 commit into
Open
Conversation
firecow
reviewed
May 9, 2026
| return Utils.spawn(["rsync", "-a", `${source}/.`, `${this.argv.cwd}/${this.argv.stateDir}/builds/${safeJobName}`]); | ||
| } | ||
| return Utils.spawn([this.argv.containerExecutable, "cp", `${source}/.`, `${this._containerId}:${this.ciProjectDir}`]); | ||
| return Utils.spawn(["sh","-c" , `cd ${source}; tar -cf - . --owner ${this.chownOpt.split(":")[0]} --group ${this.chownOpt.split(":")[1]} | ${this.argv.containerExecutable} cp - ${this._containerId}:${this.ciProjectDir}`]); |
Owner
There was a problem hiding this comment.
Please attach some performance charts. I'm worried this would kill performance in big projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes an issue that occurs when you use an image without root as the user
artifacts being copied into the container as the user outside of the container so changing the artifacts/anything in contained folders will fail due to permission denied
example dockerfile+gitlab-ci.yaml should fail on the dep step without this patch and work after
Summary by cubic
Fixes permission errors in non-root container builds by ensuring artifacts and the project directory are owned by the container user. We detect the image’s UID:GID and apply it when copying files and setting permissions.
id -u:id -gfrom the job image and reuse it across steps./tmpin the helper using the detected owner.--owner/--groupto ensure correct ownership inside the container.Written for commit d80d1c6. Summary will update on new commits.