ci: don't fail build when SonarQube scan step errors - #1873
Closed
firecow wants to merge 2 commits into
Closed
Conversation
The SonarQube scan runs as the final step of the test job and intermittently returns HTTP 403 while downloading the scanner CLI from binaries.sonarsource.com, failing the whole build even though tests passed. It is a reporting step and the quality gate is reported via its own check, so mark it continue-on-error.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
The scan action downloads the scanner CLI from binaries.sonarsource.com on every run, which intermittently returns HTTP 403 and fails the build. The action checks the tool-cache first (tc.find) and only downloads on a miss, so persisting that directory with actions/cache makes every run after the first restore the scanner and skip the CDN entirely. scannerVersion is pinned to keep the cache key in sync.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SonarQube scan runs as the final step of the
testjob and intermittently returns HTTP 403 while downloading the scanner CLI frombinaries.sonarsource.com, failing the wholemasterbuild even though tests passed (seen across multiple re-runs of run 26933995675).It is a reporting step — the quality gate is surfaced via its own
SonarCloud Code Analysischeck — so a transient scanner-download error should not block the build. Marked the stepcontinue-on-error: true.This does not mask test failures:
bun run coverageruns in the prior step and still fails the job if any test fails.Test plan
continue-on-error: true.github/workflows/is ignored by yamllint config, so no lint impactSummary by cubic
Make the SonarQube scan non-blocking and cache the SonarScanner CLI to avoid flaky 403 downloads that fail builds. Set
continue-on-error: true, pinscannerVersion: 8.1.0.6389, and persist${{ runner.tool_cache }}/sonar-scanner-cli; tests still gate the job and the quality gate is reported via its own check.Written for commit 637a89a. Summary will update on new commits.