fix: pull registry probe image before the timed readiness check - #1904
Merged
Conversation
The readiness probe's 4s budget also covered the curlimages/curl image pull, so a cold pull consumed it before the poll could run. Pin the three images used by the local registry and let renovate track them.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 11, 2026
This MR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Adoption](https://docs.renovatebot.com/merge-confidence/) | [Passing](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---|---|---| | [npm:gitlab-ci-local](https://github.com/firecow/gitlab-ci-local) | `4.73.0` → `4.74.0` |  |  |  |  | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>firecow/gitlab-ci-local (npm:gitlab-ci-local)</summary> ### [`v4.74.0`](https://github.com/firecow/gitlab-ci-local/releases/tag/4.74.0) [Compare Source](firecow/gitlab-ci-local@4.73.0...4.74.0) #### What's Changed - fix: introduce per-job cert volume with %gcl% token by [@​ticapix](https://github.com/ticapix) in [#​1877](firecow/gitlab-ci-local#1877) - fix: pull registry probe image before the timed readiness check by [@​firecow](https://github.com/firecow) in [#​1904](firecow/gitlab-ci-local#1904) - fix(parser): anchor comment directives correctly and quote injected descriptions by [@​firecow](https://github.com/firecow) in [#​1896](firecow/gitlab-ci-local#1896) **Full Changelog**: <firecow/gitlab-ci-local@4.73.0...4.74.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yODguMCIsInVwZGF0ZWRJblZlciI6IjQzLjI4OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local registry readiness probe timed out because its 4s budget also covered the
curlimages/curlimage pull, so the pull now runs before the timed probe and the three images the local registry uses are pinned with a renovate custom manager to keep them updated. I could not reproduce the timeout locally, so CI is the real check on the flake.Summary by cubic
Fix flaky local registry readiness probe by pulling the probe image before the timed check (now inside the try block) and increasing the timeout to 10s.
Bug Fixes
curlimages/curl:8.21.0inside the probe’s try block before the loop to avoid cold pull timeouts and ensure cleanup on failure.Dependencies
registry:3.1.1,alpine/openssl:3.5.7,curlimages/curl:8.21.0.src/utils.tsand a regex custom manager with thedockerdatasource.Written for commit c4ac83f. Summary will update on new commits.