fix: fall back to a literal tag when a component ref is not a semver range - #1913
Merged
Conversation
…range A ref of only digits matches the semver range pattern, but a tag literally named 9 or 0.1 is not valid semver, so range resolution found nothing and the assertion fired instead of using the ref as-is.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A component ref of only digits matches the semver range pattern, but a tag literally named
9or0.1is not valid semver, so range resolution found nothing and the assertion fired instead of using the ref as a plain tag. Fixes #1604.Summary by cubic
Fall back to a literal Git tag when a component ref looks like a semver range but isn’t valid semver (e.g.,
9,0.1). If range resolution finds nothing but the tag exists, accept it instead of asserting, and add an integration test for@1.Written for commit 5ccab0e. Summary will update on new commits.