Skip to content

fix: correct typos in comments and remove leftover debug println#5871

Open
immanuwell wants to merge 2 commits into
firecracker-microvm:mainfrom
immanuwell:fix/typos-and-debug-println
Open

fix: correct typos in comments and remove leftover debug println#5871
immanuwell wants to merge 2 commits into
firecracker-microvm:mainfrom
immanuwell:fix/typos-and-debug-println

Conversation

@immanuwell
Copy link
Copy Markdown

@immanuwell immanuwell commented May 9, 2026

What

Handful of spelling/grammar fixes scattered across the codebase, plus one debug println! that got left in a test during the bincode→bitcode migration.

Typos fixed:

  • calcuatedcalculated (aarch64 PC register doc)
  • accomodateaccommodate (net metrics comment)
  • recievedreceived (balloon device doc)
  • occuredoccurred (snapshot error enum, mmds, vsock muxer)
  • preceedingpreceding (snapshot CRC comment)
  • bigger/more/smaller then...than (regs, amd cpuid normalize, snapshot-editor)

Debug println removed:
src/vmm/src/snapshot/mod.rs — added in 37480d9 (bincode→bitcode migration) with a literal comment // Debug: print the length to understand what's happening. Never cleaned up.

How to reproduce

grep -rn "calcuated\|accomodate\|recieved\|occured\|preceeding\|bigger then\|more then\|smaller then" src/
grep -n "Debug: print\|println.*Snapshot data" src/vmm/src/snapshot/mod.rs

Both greps should come back empty after this patch.

Testing

No logic changed — only comments, doc strings, an error enum message, and one test-only println!. Existing tests cover all the affected code paths.

Signed-off-by: immanuwell <pchpr.00@list.ru>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.80%. Comparing base (6ec5511) to head (54a6167).

Files with missing lines Patch % Lines
src/vmm/src/arch/aarch64/regs.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5871   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files         277      277           
  Lines       29892    29892           
=======================================
  Hits        24753    24753           
  Misses       5139     5139           
Flag Coverage Δ
5.10-m5n.metal 83.10% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.43% <ø> (ø)
5.10-m6g.metal 79.73% <0.00%> (-0.01%) ⬇️
5.10-m6i.metal 83.10% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.42% <ø> (-0.01%) ⬇️
5.10-m7g.metal 79.73% <0.00%> (ø)
5.10-m7i.metal-24xl 83.07% <ø> (ø)
5.10-m7i.metal-48xl 83.06% <ø> (-0.01%) ⬇️
5.10-m8g.metal-24xl 79.73% <0.00%> (ø)
5.10-m8g.metal-48xl 79.73% <0.00%> (ø)
5.10-m8i.metal-48xl 83.07% <ø> (ø)
5.10-m8i.metal-96xl 83.07% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.12% <ø> (ø)
6.1-m6a.metal 82.45% <ø> (-0.01%) ⬇️
6.1-m6g.metal 79.72% <0.00%> (-0.01%) ⬇️
6.1-m6i.metal 83.12% <ø> (ø)
6.1-m7a.metal-48xl 82.44% <ø> (ø)
6.1-m7g.metal 79.73% <0.00%> (ø)
6.1-m7i.metal-24xl 83.13% <ø> (-0.01%) ⬇️
6.1-m7i.metal-48xl 83.13% <ø> (-0.01%) ⬇️
6.1-m8g.metal-24xl 79.72% <0.00%> (-0.01%) ⬇️
6.1-m8g.metal-48xl 79.73% <0.00%> (+<0.01%) ⬆️
6.1-m8i.metal-48xl 83.13% <ø> (ø)
6.1-m8i.metal-96xl 83.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShadowCurse
Copy link
Copy Markdown
Contributor

Hi @immanuwell, can you please update the commit message body with info from the PR description? Otherwise the CI style check will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants