Fix all tests when running on a c5.metal dev-desktop#5940
Merged
marco-marangoni merged 4 commits intoJun 10, 2026
Conversation
marco-marangoni
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5940 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 277 277
Lines 30129 30129
=======================================
Hits 25012 25012
Misses 5117 5117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marco-marangoni
added
the
Status: Awaiting review
JamesC1305
reviewed
Jun 8, 2026
Manciukic
reviewed
Jun 8, 2026
marco-marangoni
force-pushed
the
dev-desk-tests
branch
2 times, most recently
from
ffab2e1 to
f66d73a
Compare
zulinx86
approved these changes
Jun 8, 2026
Manciukic
approved these changes
Jun 10, 2026
With this commit, the Intel CPU 8275CL is correctly identified, and `test_config_machine_config_params` now passes. Signed-off-by: Marco Marangoni <mamarang@amazon.com>
On development environments, it doesn't make sense to run test that require specific hardware or software configuration on the host. Signed-off-by: Marco Marangoni <mamarang@amazon.com>
The folder is created when running integration tests, and doesn't belong in git. Signed-off-by: Marco Marangoni <mamarang@amazon.com>
Some test require the `--performance` to pass. This commit updates the documentation to make the requirement more explicit. Signed-off-by: Marco Marangoni <mamarang@amazon.com>
marco-marangoni
force-pushed
the
dev-desk-tests
branch
from
87d574d to
805c8e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR contains several commit that make all test pass locally on a c5.metal dev-desktop.
Changes include:
test_vulnerabilities.pywhenFC_TEST_DEVELOPMENT_ENVIRONMENT=1env var is detectedhugetlbfsReason
With this commit, all tests should pass on metal dev-desktops (with the new
FC_TEST_DEVELOPMENT_ENVIRONMENT=1env var set).License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.