Minor fixes#5944
Open
ShadowCurse wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5944 +/- ##
==========================================
+ Coverage 83.01% 83.02% +0.01%
==========================================
Files 277 277
Lines 30129 30147 +18
==========================================
+ Hits 25012 25031 +19
+ Misses 5117 5116 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
In `update_range` function, move kvm slot update before memory discard to prevent a small time window when the guest can re-fault just discarded memory before it is removed from kvm view. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Add additional parameter to the `pop`/`pop_or_enable_notification` methods of the `Queue` to force them to be bounded by that value. In all cases the initial bound value is the `size` of the queue. This is the most upper bound we can use. The reason to not use lower values like `queue.len()` is that the driver is allowed to add new items to the queue and change the `avail_ring.used_idx` used for notification suppression. If this happens, we might end up in a situation where we can process all initial `queue.len()` requests, but since the `avail_ring.used_idx` is changed, we will not send a notification to the guest. This will result in a broken device. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
added
the
Status: Awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
virtio-memrequest handling unmap kvm slots before callingmprotectto prevent a possibility for the guest to quickly re-fault themprotected memoryQueue::popfunctions be bounded to prevent guest from making us process more thanqueue.sizerequestsReason
Fixes a couple of edge-cases where guest actions can lead to unwanted behavior.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.