buildkite: remove hotunplug_total_time override#6011
Open
ShadowCurse wants to merge 1 commit into
Open
Conversation
In the commit ac7510c ("test: skip flaky hotplug tests on x86_64 5.10 hosts") we disabled `test_memory_hotplug_latency` and `test_virtio_mem_hotplug_hotunplug` for x86_64/5.10 instances and that broke the A/B script since we pass the `hotunplug_total_time` override. So remove this override at least until we figured out what is happening with x86_64/5.10. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
hotunplug_total_time
branch
from
7469e90 to
3a08f6b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6011 +/- ##
=======================================
Coverage 83.11% 83.11%
=======================================
Files 277 277
Lines 30207 30207
=======================================
Hits 25106 25106
Misses 5101 5101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In the commit ac7510c ("test: skip flaky hotplug tests on x86_64 5.10 hosts") we disabled
test_memory_hotplug_latencyandtest_virtio_mem_hotplug_hotunplugfor x86_64/5.10 instances and that broke the A/B script since we pass thehotunplug_total_timeoverride. So remove this override at least until we figured out what is happening with x86_64/5.10.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.