refactor(shred,storei): remove storei, replace dcache w/ wksp obj #4970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripatel-fd
previously approved these changes
May 1, 2025
ripatel-fd
reviewed
May 1, 2025
mmcgee-jump
reviewed
May 1, 2025
src/app/firedancer/topology.c
Outdated
| @@ -313,7 +311,6 @@ fd_topo_initialize( config_t * config ) { | |||
|
|
|||
| /**/ fd_topob_link( topo, "stake_out", "stake_out", 128UL, 40UL + 40200UL * 40UL, 1UL ); | |||
| /* See long comment in fd_shred.c for an explanation about the size of this dcache. */ | |||
lidatong
force-pushed
the
chali/refactor/remove-storei
branch
from
0b2ed0e to
aa1b61f
Compare
lidatong
changed the title
lidatong
force-pushed
the
chali/refactor/remove-storei
branch
4 times, most recently
from
6e01daa to
10211e1
Compare
lidatong
changed the title
lidatong
changed the title
lidatong
force-pushed
the
chali/refactor/remove-storei
branch
from
10211e1 to
4b0d3d4
Compare
|
@ripatel-fd @mmcgee-jump can i get a re-review |
|
added description |
two-heart
previously requested changes
May 2, 2025
src/app/firedancer/topology.c
Outdated
| /**/ fd_topob_tile_in( topo, "arch_f", 0UL, "metric_in", "store_feeder", 0UL, FD_TOPOB_RELIABLE, FD_TOPOB_POLLED ); | ||
| fd_topob_wksp( topo, "replay_feeder" ); | ||
| fd_topob_link( topo, "replay_feeder", "replay_feeder", 65536UL, 4UL*FD_SHRED_STORE_MTU, 4UL+config->tiles.shred.max_pending_shred_sets ); | ||
| /**/ fd_topob_tile_out( topo, "storei", 0UL, "replay_feeder", 0UL ); |
src/disco/shred/fd_shred_tile.c
Outdated
| ctx->repair_out_chunk = ctx->repair_out_chunk0; | ||
| FD_TEST( fd_dcache_compact_is_safe( ctx->repair_out_mem, repair_out->dcache, repair_out->mtu, repair_out->depth ) ); | ||
| ulong fec_sets_obj_id = fd_pod_queryf_ulong( topo->props, ULONG_MAX, "fec_sets" ); | ||
| if( FD_LIKELY( fec_sets_obj_id == ULONG_MAX ) ) FD_LOG_ERR(( "invalid firedancer topo" )); |
lidatong
force-pushed
the
chali/refactor/remove-storei
branch
from
4b0d3d4 to
395e283
Compare
lidatong
force-pushed
the
chali/refactor/remove-storei
branch
from
395e283 to
b86f773
Compare
ripatel-fd
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
storeitile from the firedancer topo.Significantly, this requires replacing the
shred_storedcache in theshredtile which houses the FEC sets. This was replaced with a new shared wksp objectfec_sets. This conveniently allowsshredandrepairtiles to join the same shmem region, so repair can directly observe which FEC sets need repair (and request repairs for them). Currently, repair tile is maintaining an entirely separate copy of what the in-progress FEC sets are.