Remove x86intrin.h dependency from fd_util.h #4997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tiles ended up using getrandom(2)
ripatel-fd
requested review from
nbridge-jump,
akhinvasara-jumptrading,
ptaffet-jump and
mmcgee-jump
as code owners
Improves build times
ripatel-fd
force-pushed
the
ripatel/build-times
branch
from
b4fa799 to
453930c
Compare
ripatel-fd
force-pushed
the
ripatel/build-times
branch
from
453930c to
af72d97
Compare
mmcgee-jump
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes code so that including
fd_util.hno longer includes<x86intrin.h>and friends.The x86 intrinsics are about 70k lines of headers, which makes up the majority of compile-time for small compile units.
make -j lib CC=gcc-14:Before: 0m28.815s
After: 0m26.495s
make -j lib=CC=clang:Before: 0m21.672s
After: 0m19.811s