core-bpf: special-case core bpf program error codes #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mjain-jump feel free to review, but don't merge until we land on solana-program/config#21 and solana-program/address-lookup-table#43 please. |
buffalojoec
changed the title
buffalojoec
force-pushed
the
special-cased-codes-config
branch
from
59aa231 to
80205c3
Compare
buffalojoec
force-pushed
the
special-cased-codes-config
branch
from
80205c3 to
9f33632
Compare
Contributor
Author
|
@mjain-jump OK, those two linked PRs landed. PR is unchanged except for the removal of one code for each program. The programs only deal with read-only checks, not executable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change special-cases a few error codes for the Address Lookup Table and Config programs, which otherwise would produce known mismatches between BPF and builtin.
For more information, see the comments above the change, or solana-program/config#21.