-
Notifications
You must be signed in to change notification settings - Fork 167
pyop3: parloops #3534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JDBetteridge
wants to merge
14
commits into
connorjward/pyop3
Choose a base branch
from
JDBetteridge/pyop3_parloops
base: connorjward/pyop3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
pyop3: parloops #3534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * All tests in test_constant passing * Apply suggestions from code review Co-authored-by: Jack Betteridge <[email protected]> * Matnest broke whilst I fixed constant * Mark tests Connor doesn't want to run * Skip some more tests * Fix test_zero_forms, except parallel * Re-enable tests in test_multiple_domains * Enable some tests, disable others --------- Co-authored-by: Connor Ward <[email protected]>
* Fix interpolators (change to pyop3 API) * Replace eager_zero with just zero * DO NOT MERGE pyop3 branch pointer * Update .github/workflows/build.yml --------- Co-authored-by: Jack Betteridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have refactored a lot, this is where I got to on Friday by 1700
Rebased on Pablo's stuff