Skip to content

Point data assimilation demo #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: release
Choose a base branch
from

Conversation

leo-collins
Copy link
Contributor

Demo of using firedrake-adjoint to assimilate point data. Based on Reuben's work

@leo-collins leo-collins marked this pull request as ready for review May 14, 2025 10:53
@danshapero
Copy link
Contributor

There's one aspect of sparse data assimilation that isn't documented and should be. By default, Firedrake will internally reorder some of the points in the point data space. If you're synthesizing the sparse data to assimilate then you can fill in the values based on their position. But if you're working from real geospatial data that you get from, say, a GeoTIFF file, this reordering now puts everything in a different order from what you might expect. There's a separate intermediate step where you need to untangle the orders. I can give you a more minimal example of this, but I had to put in this fix for a paper that I had published recently. Now this notebook might not be the right place to describe this detail, but it should be written down more explicitly somewhere.

@leo-collins leo-collins force-pushed the point_data_assimilation_demo branch from cfbfbc5 to 3df446a Compare May 15, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants