Acse ej321/gmsh demo update #4326
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acse-ej321
requested review from
dham
and removed request for
ksagiyam and
connorjward
APaganini
requested changes
May 15, 2025
|
Looks generally good to me. If the corresponding python file runs correctly, then I think it could be merged. Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extended the
immersed_domaindemo to include examples of creating a Firedrake compatible mesh from Gmsh using:The existing example generated nearly identical meshes with the additional methods to showcase their similarities and differences. An image comparing the resulting meshes was added to help the user check output.