Relax numpy dependency version for better competibility#160
Merged
firefly-cpp merged 3 commits intofirefly-cpp:mainfrom Nov 23, 2025
Merged
Relax numpy dependency version for better competibility#160firefly-cpp merged 3 commits intofirefly-cpp:mainfrom
firefly-cpp merged 3 commits intofirefly-cpp:mainfrom
Conversation
Contributor
Author
|
I haven't used poetry before, not sure why the poetry.lock check is failing. Any ideas? |
firefly-cpp
approved these changes
Nov 23, 2025
Owner
firefly-cpp
left a comment
firefly-cpp
left a comment
There was a problem hiding this comment.
Thanks @erkankarabulut! I will try to rebuild the lock file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 changes done:
numpy = ">=1.22.4"andpandas = "^2.2.2"for better compatibility with other python packages that can not work with numpy 1.x.TestTextMiningtests were failing becausepunkthas been renamed topunkt_tab. Fixed that and updated the documentations accordingly.I've run the tests and everything passed. But please double check!