Skip to content

Include --search option in pq filter push#6026

Open
canova wants to merge 1 commit into
firefox-devtools:mainfrom
canova:pq-filter-search
Open

Include --search option in pq filter push#6026
canova wants to merge 1 commit into
firefox-devtools:mainfrom
canova:pq-filter-search

Conversation

@canova
Copy link
Copy Markdown
Member

@canova canova commented May 15, 2026

This fixes commands like:

pq filter push --during-marker --search Paint

This was already possible to do this with ephemeral filters like

pq thread samples --during-marker --search Paint

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.77%. Comparing base (41473d3) to head (1d9998b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6026   +/-   ##
=======================================
  Coverage   83.77%   83.77%           
=======================================
  Files         329      329           
  Lines       34423    34423           
  Branches     9627     9616   -11     
=======================================
  Hits        28839    28839           
  Misses       5155     5155           
  Partials      429      429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@canova canova requested review from fatadel and mstange May 15, 2026 15:26
@canova canova force-pushed the pq-filter-search branch from db5cd7a to 4e54051 Compare May 15, 2026 15:30
This fixes commands like:
```
pq filter push --during-marker --search Paint
```

This was already possible to do this with ephemeral filters like
```
pq thread samples --during-marker --search Paint
```
@canova canova force-pushed the pq-filter-search branch from 4e54051 to 1d9998b Compare May 15, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants