Fix PHP 8.4 execute() return type and add PHP 8.5 / Magento 2.4.9 support#231
Open
gexxx05 wants to merge 2 commits into
Open
Fix PHP 8.4 execute() return type and add PHP 8.5 / Magento 2.4.9 support#231gexxx05 wants to merge 2 commits into
gexxx05 wants to merge 2 commits into
Conversation
Member
|
Thanks for your contribution, @gexxx05! Could you please check the failing workflows? |
Without actions/checkout the workspace is empty and the extension under test cannot be mounted into the Magento installation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
@sprankhub Added the missing actions/checkout@v4 step to the 2.4.8 and 2.4.9 jobs. Note: the 2.4.5 (and likely 2.4.6/2.4.7) failures are unrelated to this PR — they are caused by new composer-audit security advisories on webonyx/graphql-php 14.11.x, which affect all Magento installations < 2.4.9 regardless of this change. Adding block_insecure: 'false' to the extdn action input would fix that, but I'd consider it out of scope here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR - thank you!
Issue
No related issue.
Proposed changes
Command/SetupRunCommand::execute(): addintreturn type(PHP 8.4 enforces the tentative return type from
Symfony\Console\Command\Command::execute()).composer.jsonPHP/Magento constraints to include PHP 8.5 and Magento 2.4.9.