Skip to content

Conversation

@cxp484
Copy link
Contributor

@cxp484 cxp484 commented Nov 4, 2024

@gforney, I wanted to mean that we should clean fds obj and mod files if --clean-hypre and --clean-sundials are specified. I did it for the linux part. Could you please do it for the Windows one.

@rmcdermo rmcdermo merged commit 978624e into firemodels:master Nov 4, 2024
5 checks passed
@gforney
Copy link
Contributor

gforney commented Nov 4, 2024 via email

@gforney
Copy link
Contributor

gforney commented Nov 4, 2024

let me know if you see something different

@cxp484
Copy link
Contributor Author

cxp484 commented Nov 4, 2024

@gforney Great, I just tested the Windows version, and it's working as you described. I see that you're removing FDS files within both build_hypre.bat and build_sundials.bat, so the Windows version looks good. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants