Skip to content

FDS Source: Fix bug in hvac DPSTAR when zones merge (Issue #13673) #13743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drjfloyd merged 1 commit into from
Nov 12, 2024
Merged

FDS Source: Fix bug in hvac DPSTAR when zones merge (Issue #13673) #13743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Source/hvac.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,13 +1875,28 @@ SUBROUTINE DPSTARCALC
IF (IPZ==IOPZ) CYCLE
IF (CONNECTED_ZONES(IPZ,IOPZ,1)) PSUM_TOT(IPZ) = PSUM_TOT(IPZ) + PSUM(IOPZ,1)
ENDDO
ENDDO

DO IPZ = 1,N_ZONE
PZ => P_ZONE(IPZ)
IF (PZ%N_DUCTNODES==0) CYCLE
DO NN = 1,PZ%N_DUCTNODES
DN=>DUCTNODE(PZ%NODE_INDEX(NN))
DU=>DUCT(DN%DUCT_INDEX(1))
DPSTAR(IPZ) = DPSTAR(IPZ) - DN%DIR(1) * DU%AREA * DU%VEL(OLD) * DT_HV/PSUM_TOT(IPZ)
IF (DU%FIXED) DPSTAR(IPZ) = DPSTAR(IPZ) + DN%DIR(1) * DU%AREA * DU%VEL(NEW) * DT_HV/PSUM_TOT(IPZ)
DO IOPZ = 1, N_ZONE
IF (IPZ==IOPZ) CYCLE
IF (P_ZONE(IOPZ)%N_DUCTNODES==0) CYCLE
IF (CONNECTED_ZONES(IPZ,IOPZ,1)) THEN
IF (P_ZONE(IPOZ)%N_DUCTNODES==0) CYCLE
DPSTAR(IOPZ) = DPSTAR(IOPZ) - DN%DIR(1) * DU%AREA * DU%VEL(OLD) * DT_HV/PSUM_TOT(IPZ)
IF (DU%FIXED) DPSTAR(IOPZ) = DPSTAR(IOPZ) + DN%DIR(1) * DU%AREA * DU%VEL(NEW) * DT_HV/PSUM_TOT(IPZ)
ENDIF
ENDDO
ENDDO
ENDDO

END SUBROUTINE DPSTARCALC

!> \brief Builds the right hand side of the HVAC flow matrix for momentum conservation in a duct
Expand Down
Loading