Skip to content

Conversation

@cxp484
Copy link
Contributor

@cxp484 cxp484 commented Nov 18, 2024

The latest OneAPI doesn't have ifort, but kept the mpiifort which by default search for ifort compiler. That will cause a Sundials build failure. Hence removing the mpiifort option.

@cxp484 cxp484 merged commit 8a29ade into firemodels:master Nov 18, 2024
5 checks passed
@drjfloyd
Copy link
Contributor

Will this change break compilaiton for those still using ifort?

@mcgratta
Copy link
Contributor

It should not. The FDS makefile still looks for ifort. If you do not have it because you upgraded to the latest oneAPI, you need to ```
export INTEL_IFORT=ifx

in your `.bashrc` file. This is what I am doing .  I am testing the latest oneAPI

@cxp484
Copy link
Contributor Author

cxp484 commented Nov 19, 2024

I realize my previous comment may not have been entirely clear. This change affects only third-party builds, in particular Sundials. Currently, only Sundials requires a Fortran compiler. By default, the script previously searched for compilers in the following order: mpiifort, ifort, mpiifx, and ifx, prioritizing ifort over ifx. However, the latest OneAPI no longer includes ifort but retains mpiifort, which assumes the presence of ifort as a underlying default compiler. As a result, when building Sundials with the latest OneAPI, the script selects mpiifort as fortran compiler, but since ifort is unavailable, the Sundials build fails.

For building Sundials, ifort alone is sufficient, and mpiifort is not necessary. Hence, I’ve removed mpiifort from the list of third-party Fortran compilers while retaining the order ifort, mpiifx, and ifx.

@drjfloyd To answer your question: ifort will still be supported for third-party builds and will maintain priority over ifx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants