FDS Verification: add 3 component pine_wood_TGA cases to dataplot and… #13940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tune parameters to better match Anca-Couce data
Contributor
Author
|
@ericvmueller Do these plots live in any of the guides yet? I am not finding them. Nor do I find "pine_wood_TGA" label. So, I'm wondering how we are getting away with this. Usually firebot complains if a case is in dataplot but not referenced in a section of one of the guides. |
Contributor
|
Hmm AFAIK I didn't do anything special - I didn't know that was something which would cause a complaint and wasn't aiming to avoid it. As far as putting it in the guide I think we had gone back and forth on whether we needed/wanted another pyroylsis case, but with the Kashiwagi case progressing it probably makes sense. Happy to put something in but will need to check with you on the new parameters. I'll be back in the office on Thursday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tune parameters to better match Anca-Couce data