Skip to content

FDS Source: Issue #14018. Fix bug in vent drawing logic #14024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcgratta merged 1 commit into from
Jan 9, 2025
Merged

FDS Source: Issue #14018. Fix bug in vent drawing logic #14024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/dump.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2296,7 +2296,7 @@ SUBROUTINE WRITE_SMOKEVIEW_FILE
WHERE (VENT_INDICES(HI1:HI2,VI1:VI2,FACE_INDEX)==0) VENT_INDICES(HI1:HI2,VI1:VI2,FACE_INDEX) = -1
ELSE ! Tag user-specified vents
WHERE (VENT_INDICES(HI1:HI2,VI1:VI2,FACE_INDEX)==0) VENT_INDICES(HI1:HI2,VI1:VI2,FACE_INDEX) = N
IF (VT%OBST_INDEX==0) THEN ! a dummy vent will be created and drawn rather than the actual vent.
IF (.NOT.VT%DRAW) THEN ! a dummy vent will be created and drawn rather than the actual vent.
VT%COLOR_INDICATOR = 8
VT%TYPE_INDICATOR = -2
VT%TRANSPARENCY = 0._EB
Expand Down
2 changes: 1 addition & 1 deletion Source/init.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2956,7 +2956,7 @@ SUBROUTINE INIT_WALL_CELL(NM,I,J,K,OBST_INDEX,IW,IOR,SURF_INDEX,IERR,TT)
VENT_INDEX_FOUND = N
VENT_INDEX = N
SURF_INDEX_NEW = VT%SURF_INDEX
VT%OBST_INDEX = OBST_INDEX
IF (OBST_INDEX>0 .AND. IW<=M%N_EXTERNAL_WALL_CELLS) VT%DRAW = .FALSE.

ENDDO VENT_SEARCH_LOOP

Expand Down
2 changes: 1 addition & 1 deletion Source/type.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,7 @@ MODULE TYPES
X1_ORIG=0._EB,X2_ORIG=0._EB,Y1_ORIG=0._EB,Y2_ORIG=0._EB,Z1_ORIG=0._EB,Z2_ORIG=0._EB, &
X0=-9.E6_EB,Y0=-9.E6_EB,Z0=-9.E6_EB,FIRE_SPREAD_RATE,UNDIVIDED_INPUT_AREA=0._EB,INPUT_AREA=0._EB,&
TMP_EXTERIOR=-1000._EB,DYNAMIC_PRESSURE=0._EB,UVW(3)=-1.E12_EB,RADIUS=-1._EB
LOGICAL :: ACTIVATED=.TRUE.,GEOM=.FALSE.,AREA_ADJUST=.TRUE.
LOGICAL :: ACTIVATED=.TRUE.,GEOM=.FALSE.,AREA_ADJUST=.TRUE.,DRAW=.TRUE.
CHARACTER(LABEL_LENGTH) :: DEVC_ID='null',CTRL_ID='null',ID='null'
! turbulent inflow (experimental)
INTEGER :: N_EDDY=0
Expand Down
Loading