Bring FireX up to master, refactor vtkhdf output for computational speed, windows GPU build #14569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FDS Build: Change HYPRE version to 2.33.0
Verification Case ext_heartbeat_std_curve - Expanding wait times
Update ext_heartbeat_std_curve.py
FDS Source: add error trap for improper MULT line
FDS Source: clean up geom output logs and add BINGEOM_DIR on DUMP
FDS User Guide: add discussion of BINGEOM_DIR
FDS Source: add RESULTS_DIR for UVW,TMP,SPEC .csv files
FDS User Guide: remove old comment
FDS Manuals: Typos and miscellaneous
…ve outward normal
FDS Source: if T34 defines a reflection, reorder face vertices to preser…
FDS Source: Fixes to HVAC for leakage and pressure zones
FDS Source: fix typo
FDS Source: Increase smoothing of particle mass and cooling
correct for_bundle path in make pictures script
FDS Source: Reorganize INITIALIZE_MESH_VARIABLES_1. Issue firemodels#14489
FDS Source: Adjust area in SURFACE DENSITY
FDS Source : Redefine NVERT for boundary cut-faces of voided cut-cells.
Update linux.yml Update linux.yml Update linux.yml Update linux.yml Update linux.yml Disallow prune of MKL static libraries.
FDS Build: Simplify MKL library paths
FDS Source: fix VEL_GHOST for viz near surfaces
FDS Build: Remove commented lines
FDS Verification: Account for change in SURFACE_DENSITY
FDS Source: Remove debug statement
FDS Source: comment VEL_GHOST change in VELOCITY_BC temporarily
Contributor
|
@johodges This is not a very clean PR. Can we talk to discuss this? There should be different merges for merging master into FireX and then you fixing FireX issues. This looks like you are combing a ton of this. And it is error prone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cxp484 here is the PR per the email chain. I have verified compilation and running on my windows and linux machines.