FireX: Merge with firemodels/master #15068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FDS Source: Adiabatic Flame Temperature calculation in Mixing zone
FDS User Guide: Add notes for simple_test case
FDS Source: Minor syntax correction
Python: add script to document verification case
FDS Verification: Update exact value Issue firemodels#15039
FDS Source: remove FLUX_LIMITER_SINGLE_COEF parameter I will remove the _NEW designations once I have the CC_IBM code converted over.
FDS Source: fix 2nd ghost cell value of PBAR in wall
FDS Source: change default USE_MIXED_ZN_AFT_TMP to F
FDS Source: remove write statements
FDS Source: fix missingn pointer
FDS Verification: more detail to thermophoretic case Issue firemodels#15039
FDS Source: Explicitly sum arrays passed to subroutine
FDS Source: Pack II2, JJ2, KK2
FDS Source: fix uninitialized ramp values and array declarations
FDS Source: BI-DIRECTIONAL PROBE edits and Type-K props
FDS Source: Fix units for default TC specific heat.
FDS Source: Fix temperature unit PY%SPECIFIC_HEAT
Radiation: Simplify radcal effective and Planck mean logic
Collaborator
|
Is there a reason this PR is still open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.