Skip to content

FDS Source: Fix realizability error with misplaced logical initializa… #15318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drjfloyd merged 1 commit into from
Oct 13, 2025
Merged

FDS Source: Fix realizability error with misplaced logical initializa… #15318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Source/mass.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ SUBROUTINE CHECK_MASS_DENSITY
REAL(EB) :: MASS_N(-3:3),CONST,MASS_C,RHO_ZZ_CUT,RHO_CUT,VC(-3:3),SIGN_FACTOR,SUM_MASS_N,VC1(-3:3),&
RHO_ZZ_MIN,RHO_ZZ_MAX,SUM_RHO_ZZ,RHO_ZZ_TEST
INTEGER :: IC
LOGICAL :: CLIP_RHO_ZZ
LOGICAL :: CLIP_RHO_ZZ(N_TRACKED_SPECIES)
REAL(EB), POINTER, DIMENSION(:,:,:) :: DELTA_RHO,DELTA_RHO_ZZ,RHOP
REAL(EB), POINTER, DIMENSION(:,:,:,:) :: RHO_ZZ

Expand Down Expand Up @@ -716,12 +716,12 @@ SUBROUTINE CHECK_MASS_DENSITY
! Correct species mass density

RHO_ZZ_MIN = 0._EB
CLIP_RHO_ZZ = .FALSE.

SPECIES_LOOP: DO N=1,N_TRACKED_SPECIES

DELTA_RHO_ZZ => WORK5
DELTA_RHO_ZZ = 0._EB
CLIP_RHO_ZZ = .FALSE.

DO K=1,KBAR
DO J=1,JBAR
Expand All @@ -739,7 +739,7 @@ SUBROUTINE CHECK_MASS_DENSITY

RHO_ZZ_MAX = RHOP(I,J,K)
IF (RHO_ZZ(I,J,K,N)>=RHO_ZZ_MIN .AND. RHO_ZZ(I,J,K,N)<=RHO_ZZ_MAX) CYCLE
CLIP_RHO_ZZ = .TRUE.
CLIP_RHO_ZZ(N) = .TRUE.
IF (RHO_ZZ(I,J,K,N)<RHO_ZZ_MIN) THEN
RHO_ZZ_CUT = RHO_ZZ_MIN
SIGN_FACTOR = 1._EB
Expand Down Expand Up @@ -777,7 +777,7 @@ SUBROUTINE CHECK_MASS_DENSITY
ENDDO
ENDDO

IF (.NOT.CLIP_RHO_ZZ) CYCLE
IF (.NOT.CLIP_RHO_ZZ(N)) CYCLE

! Assign excess/deficit RHO_ZZ neighboring cells

Expand All @@ -793,7 +793,7 @@ SUBROUTINE CHECK_MASS_DENSITY

! If nothing has been clipped, return

IF (.NOT.CLIP_RHOMIN .AND. .NOT.CLIP_RHOMAX .AND. .NOT.CLIP_RHO_ZZ) RETURN
IF (.NOT.CLIP_RHOMIN .AND. .NOT.CLIP_RHOMAX .AND. .NOT. ANY(CLIP_RHO_ZZ)) RETURN

! Final check of RHO_ZZ to ensure that ZZ(:,:,:,1:N_TRACKED_SPECIES) sums to 1

Expand Down
Loading