FireX: Merge with firemodels/master #15444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating my own branch
Merge remote-tracking branch 'firemodels/master'
Updated to latest version
Update to current version
Merge remote-tracking branch 'firemodels/master'
There is an error in the user manual for STATISTICS_END on page 417, it states that the default value is T_BEGIN, where the actual value is T_END. I also checked it by running a simulation.
FDS Verification: changes to mass_balance.py.
FDS User Guide: Convert Monin figure plotter
…test figures (figure files with _latest appeneded to name)
FDS Verification: convert geom_positive_errors.m to python.
FDS Verification: Convert geom_channel_test.m to python.
FDS Verification: Convert EDC exact solution scripts and move to Veri…
Add error_linewidth to fdsplotlib kwargs
Matlab convert: misc clean up
Python: add Group_Style and Group_Key_Labels to scatter plots
FDS Validation: push python version of backwards_facing_step
FDS Verification: Add header to file
FDS Source: Fix logic for particle position
Python: improve histogram plots
Matlab: change legend position label
Python: turn on Backwards_Facing_Step in python validation
Python: rename to Backward_Facing_Step.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.