FireX: Merge with firemodels/master #15640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FDS User Guide: edit links for error codes
…PERIODIC FLOW ONLY
FDS Source: do not reset face values for OPEN_WIND_BOUNDARY if bc is …
FDS Source: fix VEL_EDDY for wind boundaries
FDS Source: Edit error check 222 for POROUS MEDIA drag law (allow DRA…
scripts: correct path to getopts
…in the exact calc.
FDS Verification: set 0 K ambient for rad cases that are assuming it …
FDS Verification: change to 10 K to avoid density clip
FDS Source: Fix comment per Issue firemodels#15636
Python: add revision_string to LNG profiles
Python: remove sanitize from define_plot_parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.