FireX: Merge with firemodels/master #15699
Merged
+11,095
−4,806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FDS Verification: Correct number of MPI processes
Python: Allow scripts to run if sub-scripts fail
Python: show row numbers for ftest as well
FDS Validation: Update NIST_Pool_Fires
FDS Source: add SKIP_INRAD to SURF
FDS Validation: rework predicted Waterloo methanol cases The main purpose of this PR is to change the ignition procedure for the pool fire case to use an initialized inner temperature for the pool, which greatly reduces the time needed to heat of the liquid and ignite the fire. Other improvements include reworking the burner geometry, adding LES, suppression=F, and changing the outputs to work interchangeably with the "prescribed" output which are listed in dataplot inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.