Refactor getusedcoinstagstxhashes to use GetSpendsMobile

[levonpetrosyan93]

No description provided.

[coderabbitai]

Walkthrough

Reworked the getusedcoinstagstxhashes RPC in src/rpc/misc.cpp to require -mobile, replace unordered_map tag storage with a vector of pairs, and use GetSpendsMobile() instead of GetSpends(); iteration and serialization updated to the new vector layout.

Changes

Cohort / File(s)	Summary
RPC mobile tag handling src/rpc/misc.cpp	Added runtime guard requiring -mobile; replaced unordered_map tag storage with std::vector<std::pair<...>>; switched spends source from GetSpends() to GetSpendsMobile() and updated iteration/serialization to use the vector-based tag structure.

Sequence Diagram(s)

(omitted — change is localized and does not introduce a multi-component sequential flow requiring visualization)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• getusedcoinstags rpc fixed #1685: Similar refactor of getusedcoinstagstxhashes to use a fixed-order vector and GetSpendsMobile().
• New rpc calls for mobile #1449: Earlier changes touching the same RPC and mobile spends handling.

Suggested reviewers

• psolstice

Poem

🐰 I swapped the map for tidy rows,
Mobile-only now the code goes,
Spends hop in a different lane,
Tags lined up — neat on the plain,
A tiny change, a joyful pose! 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is empty despite the repository template requiring a mandatory 'PR intention' section explaining what the PR does and what issue it solves.	Add a description following the template: explain that this PR refactors getusedcoinstagstxhashes to use GetSpendsMobile with a -mobile flag guard, switches to vector-based tag storage, and clarify the issue being addressed.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly describes the main refactoring change: using GetSpendsMobile instead of the previous approach in getusedcoinstagstxhashes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch getusedcoinstagstxhashes_fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/rpc/misc.cpp`:
- Around line 1589-1596: Add the same -mobile flag guard used by other mobile
RPCs to the getusedcoinstagstxhashes RPC: at the start of the
getusedcoinstagstxhashes function check GetBoolArg("-mobile", false) and if
false throw std::runtime_error("Please rerun Firo with -mobile "); do this
before accessing spark::CSparkState::GetState() and calling
GetSpendsMobile()/GetSpendTxIds() to match the behavior in zagot functions like
getanonymityset/getsparkanonymityset and the RPC help text.

[reubenyap]

bugbot run