Feat/static discovery v2 #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Resolves #76
Motivation
Static discovery and cloud/internet setups often report
127.0.0.1as the local IP, which remote shards cannot use to send tokens back to the API node. This PR adds an explicit callback address override and fixes several minor issues discovered during testing.Changes
DNET_API_CALLBACK_ADDRenvironment variable to specify a reachable callback address for remote shards/devicesresponse for static discovery (which only returns peers).PHONEY→.PHONYlint-fixtarget to use$(UV_RUN)consistentlyensure-envtarget to check if.env.exampleexists before copyingmlx,mlx_lmto mypy ignore list and fix exclude pathsType of Change
Testing
Checklist
Related Issues
Closes #76