Skip to content

Conversation

@andthattoo
Copy link
Member

Pull Request

Summary

Resolves #76

Motivation

Static discovery and cloud/internet setups often report 127.0.0.1 as the local IP, which remote shards cannot use to send tokens back to the API node. This PR adds an explicit callback address override and fixes several minor issues discovered during testing.

Changes

  • Add DNET_API_CALLBACK_ADDR environment variable to specify a reachable callback address for remote shards
  • Include own device in /devices response for static discovery (which only returns peers)
  • Fix Makefile typo: .PHONEY.PHONY
  • Fix Makefile lint-fix target to use $(UV_RUN) consistently
  • Improve ensure-env target to check if .env.example exists before copying
  • Add mlx, mlx_lm to mypy ignore list and fix exclude paths

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • CI/CD improvement

Testing

  • Tests pass locally
  • Added new tests for the changes
  • Existing tests updated

Checklist

  • My code follows the project's code style
  • I have made corresponding changes to the documentation

Related Issues

Closes #76

create .env from .env.example if missing
exclude mlx
@andthattoo andthattoo requested a review from jaisw7 December 13, 2025 11:10
@andthattoo andthattoo added the bug Something isn't working label Dec 13, 2025
@andthattoo andthattoo self-assigned this Dec 13, 2025
@andthattoo andthattoo marked this pull request as ready for review December 13, 2025 12:03
Copy link
Collaborator

@jaisw7 jaisw7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We need multi-device CI/integration test to discover these issues (we can create a GitHub issue for now).

@jaisw7
Copy link
Collaborator

jaisw7 commented Dec 14, 2025

@andthattoo I am still seeing the issue. I have reported the observations in the linked issue #76

@andthattoo
Copy link
Member Author

issue #76 resolved

@andthattoo andthattoo closed this Dec 14, 2025
@andthattoo andthattoo reopened this Dec 14, 2025
@andthattoo andthattoo merged commit db37525 into master Dec 14, 2025
14 of 15 checks passed
Yuvrajxms09 pushed a commit to Yuvrajxms09/dnet that referenced this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue - Shards on public internet not working

3 participants