Skip to content

Jokerace/BKRT integration #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 20, 2025
Merged

Jokerace/BKRT integration #21

merged 12 commits into from
Feb 20, 2025

Conversation

vivinvinh212
Copy link
Collaborator

No description provided.

@vivinvinh212 vivinvinh212 requested a review from erhant February 11, 2025 15:10
erhant
erhant requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@erhant erhant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for the review; also would love to see more inline comments even before deployment! just to get the overall idea of the code as its being written

@erhant erhant added the enhancement New feature or request label Feb 18, 2025
erhant
erhant requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@erhant erhant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ see comments ✨

erhant
erhant requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@erhant erhant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! see comments below 🙏🏻

@erhant erhant marked this pull request as ready for review February 20, 2025 13:17
erhant
erhant approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@erhant erhant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌹

@vivinvinh212 vivinvinh212 merged commit c710fa9 into master Feb 20, 2025
2 checks passed
@vivinvinh212 vivinvinh212 deleted the vinh/jokerace_integration branch February 20, 2025 15:26
@vivinvinh212 vivinvinh212 restored the vinh/jokerace_integration branch March 12, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erhant erhant erhant approved these changes

Assignees

@vivinvinh212 vivinvinh212

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivinvinh212 @erhant