Skip to content

Add Dhanashri Shivdas to contributors#113259

Open
DHANASHRI1221 wants to merge 2 commits intofirstcontributions:mainfrom
DHANASHRI1221:main
Open

Add Dhanashri Shivdas to contributors#113259
DHANASHRI1221 wants to merge 2 commits intofirstcontributions:mainfrom
DHANASHRI1221:main

Conversation

@DHANASHRI1221
Copy link

Before submitting this pull request, check the changes to see it's only the changes you made intentionally
If there are changes to other lines you didn't make deliberately, it's possible that your IDE made the changes with a utility like prettier.
Next time, make sure that you only add your changes by using git add -p and rather than git add Contributors.md

If you're doing something in the checklist below, put an x inside [ ] so that - [ ] becomes - [x]

  • I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(^◡^)۶
  • There are some things I'd like to improve in this tutorial. I have written them below.
  • There were steps where I had errors while following this tutorial. I have written them below.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Hello @DHANASHRI1221, thank you for your pull request. We appreciate your contribution to the project. However, before we can merge it, there is a merge conflict with the target branch.

No worries! You can follow this guide on resolving merge conflicts.
Once you've fixed the conflicts and pushed your changes, the repository will check the changes you made and proceed with the merge if everything looks good.

If you have any questions or need further assistance, don't hesitate to reach out. We're here to help!

@kuramaSeige-OFC
Copy link
Contributor

Hi, I appreciate your involvement in learning Open-Source Contribution.

Only thing is if you're using AI and learning, ensure you're spot on..
I saw that you've directly made changes in the main branch...
As a new Contributor it's a general mistake but keep eye on that always use a new branch for new changes and use that branch as PR.

It'll be a best practice for you when you learn git and which will not ruin the main branch cause of any oversight

Keep Learning...

@DHANASHRI1221
Copy link
Author

Thank you for the guidance! I appreciate the feedback. I will make sure to create a new branch for changes in future contributions.

Thanks for helping beginners learn the correct workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants