Skip to content

issues with _UID generation #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BertKoor wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

issues with _UID generation #5293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/Elements/PafUid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ public function canonical(string $value): string

return $value . Registry::idFactory()->pafUidChecksum($value);
}

return Registry::idFactory()->pafUid();
return $value;
}

public function edit(string $id, string $name, string $value, Tree $tree): string
Expand Down
6 changes: 3 additions & 3 deletions app/Gedcom.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,12 +998,12 @@
'NOTE' => [['RESN', '0:1', 'CHAN']],
'NOTE:CHAN' => [['_WT_USER', '0:1']],
'NOTE:SOUR:DATA' => [['TEXT', '0:1']],
'OBJE' => [['RESN', '0:1', 'CHAN'], ['_UID', '0:M']],
'OBJE' => [['RESN', '0:1', 'CHAN'], ['_UID', '0:M:?']],
'OBJE:CHAN' => [['_WT_USER', '0:1']],
'OBJE:SOUR:DATA' => [['TEXT', '0:1']],
'REPO' => [['RESN', '0:1', 'CHAN'], ['_UID', '0:M']],
'REPO' => [['RESN', '0:1', 'CHAN'], ['_UID', '0:M:?']],
'REPO:CHAN' => [['_WT_USER', '0:1']],
'SOUR' => [['RESN', '0:1', 'CHAN'], ['_UID', '0:M']],
'SOUR' => [['RESN', '0:1', 'CHAN'], ['_UID', '0:M:?']],
'SOUR:CHAN' => [['_WT_USER', '0:1']],
'SUBM' => [['RESN', '0:1', 'CHAN']],
'SUBM:CHAN' => [['_WT_USER', '0:1']],
Expand All @@ -1015,8 +1015,8 @@
*/
private function customSubTags(): array
{
$custom_family_tags = array_filter(explode(',', Site::getPreference('CUSTOM_FAMILY_TAGS')));

Check failure on line 1018 in app/Gedcom.php

View workflow job for this annotation

GitHub Actions / phpstan (ubuntu-latest, 8.4) 

Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.

Check failure on line 1018 in app/Gedcom.php

View workflow job for this annotation

GitHub Actions / phpstan (ubuntu-latest, 8.3) 

Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.

Check failure on line 1018 in app/Gedcom.php

View workflow job for this annotation

GitHub Actions / phpstan (ubuntu-latest, 8.6) 

Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.

Check failure on line 1018 in app/Gedcom.php

View workflow job for this annotation

GitHub Actions / phpstan (ubuntu-latest, 8.5) 

Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.
$custom_individual_tags = array_filter(explode(',', Site::getPreference('CUSTOM_INDIVIDUAL_TAGS')));

Check failure on line 1019 in app/Gedcom.php

View workflow job for this annotation

GitHub Actions / phpstan (ubuntu-latest, 8.4) 

Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.

Check failure on line 1019 in app/Gedcom.php

View workflow job for this annotation

GitHub Actions / phpstan (ubuntu-latest, 8.3) 

Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.

Check failure on line 1019 in app/Gedcom.php

View workflow job for this annotation

GitHub Actions / phpstan (ubuntu-latest, 8.6) 

Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.

Check failure on line 1019 in app/Gedcom.php

View workflow job for this annotation

GitHub Actions / phpstan (ubuntu-latest, 8.5) 

Call to function array_filter() requires parameter #2 to be passed to avoid loose comparison semantics.

$subtags = [
'FAM' => array_map(static fn (string $tag): array => [$tag, '0:M'], $custom_family_tags),
Expand Down
Loading