Reports - sort by place#5364
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5364 +/- ##
============================================
- Coverage 35.37% 35.35% -0.02%
- Complexity 11196 11211 +15
============================================
Files 1166 1166
Lines 48031 48068 +37
============================================
+ Hits 16990 16995 +5
- Misses 31041 31073 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi Bert. These changes are mostly OK. I was already looking at functions such as These are growing, and don't strictly belong in the indi/fam classes; they don't need access to any internal/private methods, and are just syntactic shortcuts. They are also inconsistent, as getDeathPlace() behaves subtely differently to your new getBurialPlace(). I want to look at these before merging your PR. |
|
Sure, I've just copy-pasted what was there for dates, expanding it to places, making the smallest possible change to make it work. Happy refactoring! |
Requested on the forum: add the option in Reports of Birth - Death - Burials & Marriage to sort on their place.
The sorting is performed on the reversed parts of hierarchical place names.