Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

FCE-321: iOS camera in background; FCE-1727: Add PiP support to mobile-sdk - #505

Merged
MiloszFilimowski merged 21 commits into
mainfrom
FCE-321-ios-camera-in-bg
Oct 23, 2025
Merged

FCE-321: iOS camera in background; FCE-1727: Add PiP support to mobile-sdk#505
MiloszFilimowski merged 21 commits into
mainfrom
FCE-321-ios-camera-in-bg

Conversation

@MiloszFilimowski

@MiloszFilimowski MiloszFilimowski commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

Description

  • Picture in Picture. Displayes main and secondary tracks if available, secondary track is determined by VAD.
  • On iOS support for background camera while in PiP

This is still a bit of an ongoing effort. UI and track switch should be improved in next PRs. This PR introduces the main concept which works.

Motivation and Context

  • Customers need PiP when dealing with calls in background

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear

linear Bot commented Oct 20, 2025

Copy link
Copy Markdown

@MiloszFilimowski MiloszFilimowski changed the title PiP FCE-321: iOS camera in background; FCE-1727: Add PiP support to mobile-sdk Oct 20, 2025
@linear

linear Bot commented Oct 20, 2025

Copy link
Copy Markdown

@MiloszFilimowski
MiloszFilimowski marked this pull request as ready for review October 20, 2025 09:07
@MiloszFilimowski
MiloszFilimowski force-pushed the FCE-321-ios-camera-in-bg branch from 7918198 to a3aac95 Compare October 21, 2025 15:27
Comment thread packages/ios-client/Sources/FishjamClient/pip/I420Converter.swift Outdated
Comment thread packages/ios-client/Sources/FishjamClient/pip/I420Converter.swift Outdated
Comment thread packages/ios-client/Sources/FishjamClient/pip/PictureInPictureController.swift Outdated
Comment thread packages/ios-client/Sources/FishjamClient/pip/PictureInPictureController.swift Outdated
Comment thread packages/ios-client/Sources/FishjamClient/pip/SampleBufferRTCFrameView.swift Outdated
Comment thread packages/react-native-client/ios/PictureInPictureManager.swift Outdated
Comment thread packages/react-native-client/ios/PictureInPictureManager.swift
Co-authored-by: Anna Olak <anna.olak@swmansion.com>

@anna1901 anna1901 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works great! I just noticed two issues on android, but maybe they can be handled in the next PR:

  1. The video is stretched horizontally in the PIP view
  2. When I'm on a call and then I leave the app and I can see the pip, then when I return to the app the video from the camera is not centered as before, but it is moved to the leading edge of the video view.

@MiloszFilimowski

Copy link
Copy Markdown
Collaborator Author

I've tested it and it works great! I just noticed two issues on android, but maybe they can be handled in the next PR:

  1. The video is stretched horizontally in the PIP view
  2. When I'm on a call and then I leave the app and I can see the pip, then when I return to the app the video from the camera is not centered as before, but it is moved to the leading edge of the video view.

Thank you! I'm going to handle this in FCE-2148

@MiloszFilimowski
MiloszFilimowski merged commit c9acb6a into main Oct 23, 2025
5 checks passed
@MiloszFilimowski
MiloszFilimowski deleted the FCE-321-ios-camera-in-bg branch October 23, 2025 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants