This repository was archived by the owner on Feb 10, 2026. It is now read-only.
FCE-321: iOS camera in background; FCE-1727: Add PiP support to mobile-sdk - #505
Merged
Conversation
MiloszFilimowski
marked this pull request as ready for review
October 20, 2025 09:07
MiloszFilimowski
force-pushed
the
FCE-321-ios-camera-in-bg
branch
from
October 21, 2025 15:27
7918198 to
a3aac95
Compare
anna1901
reviewed
Oct 22, 2025
Co-authored-by: Anna Olak <anna.olak@swmansion.com>
anna1901
approved these changes
Oct 22, 2025
anna1901
left a comment
Contributor
There was a problem hiding this comment.
I've tested it and it works great! I just noticed two issues on android, but maybe they can be handled in the next PR:
- The video is stretched horizontally in the PIP view
- When I'm on a call and then I leave the app and I can see the pip, then when I return to the app the video from the camera is not centered as before, but it is moved to the leading edge of the video view.
Collaborator
Author
Thank you! I'm going to handle this in FCE-2148 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is still a bit of an ongoing effort. UI and track switch should be improved in next PRs. This PR introduces the main concept which works.
Motivation and Context
Documentation impact
Types of changes
not work as expected)